Skip to content

feat(deploy): fail Service Fabric deploys that do not stay healthy - #24

Merged
Germandf merged 1 commit into
mainfrom
feat/sf-post-deploy-stability
Nov 16, 2026
Merged

Germandf merged 1 commit into
mainfrom
feat/sf-post-deploy-stability

Conversation

@Germandf

Copy link
Copy Markdown
Member

Problem. A deploy reports success as soon as the Service Fabric upgrade completes. On 16/11 Messaging 1.0.115.1 crashed in a loop right after a successful upgrade and the deploy stayed green.

Change.

  • New shared action verify-servicefabric-stable: waits up to 5 min for Ok health, then requires Ok for 120 s with the same replicas and code-package processes. An Error or a restart rolls back to rollback-version (upgrade with the current parameters, values never printed); a Warning only fails.
  • scripts/deploy_service_fabric.ps1 (fetched from main by Accounting, Banks.Movements.Firebird, Installations, Payments.RedLink, Payroll and Webmail.Recovery) runs it after every deploy, with the previous version as rollback target.

Tested. 8 decision fixtures (healthy, startup errors, never Ok, restart, Error, Warning, moved replica) in Windows PowerShell and pwsh. Read-only run against production fabric:/Eternet.Messaging: Ok, 2 identities, stable.

Not tested yet. A real deploy through this path; done next through the Devs deploy action on a low-risk app.

Runners. The only new job runs on [self-hosted, Windows]; no workflow uses GitHub-hosted runners.

🤖 Generated with Claude Code

Add verify-servicefabric-stable: after a deployment the application must reach Ok
health and keep it for 120 s with the same replicas and processes. An Error or a
restart rolls back to the previous version when one is given. The shared
deploy_service_fabric.ps1 (fetched from main by its consumers) now runs it.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-16T02:26:15.391909Z 69ad585 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Germandf
Germandf merged commit e434dda into main Nov 16, 2026
1 check failed
@Germandf
Germandf deleted the feat/sf-post-deploy-stability branch November 16, 2026 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant