Repository navigation
feat(deploy): fail Service Fabric deploys that do not stay healthy - #24
Merged
Merged
Conversation
Add verify-servicefabric-stable: after a deployment the application must reach Ok health and keep it for 120 s with the same replicas and processes. An Error or a restart rolls back to the previous version when one is given. The shared deploy_service_fabric.ps1 (fetched from main by its consumers) now runs it. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem. A deploy reports success as soon as the Service Fabric upgrade completes. On 16/11 Messaging 1.0.115.1 crashed in a loop right after a successful upgrade and the deploy stayed green.
Change.
verify-servicefabric-stable: waits up to 5 min for Ok health, then requires Ok for 120 s with the same replicas and code-package processes. An Error or a restart rolls back torollback-version(upgrade with the current parameters, values never printed); a Warning only fails.scripts/deploy_service_fabric.ps1(fetched frommainby Accounting, Banks.Movements.Firebird, Installations, Payments.RedLink, Payroll and Webmail.Recovery) runs it after every deploy, with the previous version as rollback target.Tested. 8 decision fixtures (healthy, startup errors, never Ok, restart, Error, Warning, moved replica) in Windows PowerShell and pwsh. Read-only run against production
fabric:/Eternet.Messaging: Ok, 2 identities, stable.Not tested yet. A real deploy through this path; done next through the Devs deploy action on a low-risk app.
Runners. The only new job runs on
[self-hosted, Windows]; no workflow uses GitHub-hosted runners.🤖 Generated with Claude Code